Frank Barnaby wrote:
I've attached the source for the Jini Technology Starter Kit (v2.1) to
the Jira
issue. I believe someone else will be handling the QATests soon.
Thanks Frank,
I did a quick inspection and I noticed the license headers are not what
they should be (mentors please correct me if I'm wrong). The license
headers are the same as the original source licensed under ALv2, but
they should have license headers as below (from the ServiceUI code):
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
This also applies to any of the other files in there such as the
package.html, etc. So also http://www.apache.org/legal/src-headers.html
Probably it should also contain a COPYRIGHT, LICENSE and NOTICE file
AFAIK. Maybe the best thing to do is to look into the ServiceUI upload
at https://issues.apache.org/jira/browse/RIVER-10 as Bill also went
through this phase.
Other things I noticed at first sight:
1) where are the specifications that are not part of the javadoc?
2) parts required to build the JTSK are missing, a particular reason
for that ?
--
Mark
