On Aug 28, 2007, at 9:16 PM, Jim Hurley wrote:
Jukka, Phil, Gianugo -- Any guidance from the mentors on this?
Not a mentor but hope this is useful...
Do other Apache projects typically:
- require code reviews (prior to integration)?
Depends. Projects have either RTC (review then commit) or CTR (commit then review) depending on how the community wants to organize itself. There's no guidance. For RTC the patch is typically attached to a JIRA.
- require tests (prior to integration)?
Typically yes. Many projects have an official (checked in) test suite that must pass before checking anything in. Many projects also have private test suites (various reasons, including complex setups or proprietary test harnesses) that are run either before (if the committer has access) or after a checkin. And it's always a good idea to have a test case as part of a bug fix that fails without the fix and succeeds with it, checked in as part of the fix.
- use JIRA for all changes (so they can be tracked),
or only for 'substantive' ones?
None of the projects I am familiar with require a JIRA for typos, javadoc, "obvious" bug fixes (e.g. FindBugs reports), etc. Most projects expect a JIRA for substantial changes, not just bug fixes.
It seems like that background might be helpful to making a decision here.
Other things that I'm familiar with include a recommendation (not a requirement) for a peer code review for all substantial checkins.
Craig
thanks -Jim On Aug 28, 2007, at 1:10 AM, Jim Hurley wrote: :* What kind of development process do we need? JIRA issues for all changes? code reviews?There's also a testing issue here (for example, do you need to supply tests? if so, which framework or just unit tests). This is somewhat tied into:* What kind of testing do we need?It would probably be easier to tackle these (dev process and testing process) separately.... but if they spill into one another, than so be it. So, regarding development process -- what do you think? In looking around, I didn't see a norm for things (for example, not sure if projects use JIRA for everything). We've used code reviews inside our group at Sun for the starter kit, and it's proved immensely valuable. I'd vote to continue it - both as a quality measure as well as a way to get more people involved and knowledgeable about the different pieces of code.
Craig Russell Architect, Sun Java Enterprise System http://java.sun.com/products/jdo 408 276-5638 mailto:[EMAIL PROTECTED] P.S. A good JDO? O, Gasp!
smime.p7s
Description: S/MIME cryptographic signature
