On 8/30/07, Jukka Zitting <[EMAIL PROTECTED]> wrote: > Hi, > > On 8/29/07, Gianugo Rabellino <[EMAIL PROTECTED]> wrote: > > Bottom line: I think CTR + a good use of common sense is more than > > enough. > > +1 > > There's another angle on the CTR/RTC issue as well. Especially with a > complex codebase there is a danger that people will just "do their > thing" and keep committing stuff without communicating with the rest > of the team/community on what's going on. Even though RTC does raise > the commit barrier, it also forces people to communicate what they are > doing.
True, but I think that the word "forces" captures why this is about treating symptoms rather than causes. If people don't communicate, this is a community issue that needs to be resolved within the community (by nudging, educating and - as a radical last resort - move to RTC for a short period of time while considering whether it wouldn't be better to just get rid of the guy). RTC might just sweep the problem under the rug, and make it actually worse. > With that in mind I'd suggest using at least a relaxed version of RTC > where Jira issues are raised for all non-trivial changes and a patch > or at least a written outline of the proposed solution is posted > before making the change based on lazy consensus. This is actually > what many (most?) Apache projects do in practice even if following the > CTR policy. Well said. My ideal workflow would be something like: a) generally speaking, a free-for-all CTR with common sense, which means everyone should feel comfortable in prodding the list for peer review before committing b) strong RTC (that is review + vote) required for specific subsets such as: - API changes - backward-incompatible user-visible changes - backports to release branches - security fixes c) RTC actually means: 1. a proposal to the dev list 2. patch in Jira 3. (alternatively) vote (if (b) applies) or lazy consensus Ciao, -- Gianugo Rabellino Sourcesense, making sense of Open Source: http://www.sourcesense.com Orixo, the XML business alliance: http://www.orixo.com (blogging at http://www.rabellino.it/blog/)
