Sorry for any duplication in existing in other responses, not really had time to read the whole thread.
> * What kind of development process do we need? JIRA issues for > > all changes? code reviews? IMHO I would prefer that JIRA be used for all code changes. It gives us visibility of what is happening, and can be used as the index for a change log which should be produced for every release. Also, it might be that a developer in his own time developers a patch which is then submitted to the committers in private which would mean that the community would not have any visibility of the change in code. Code reviews should be part of the JIRA entry for the change. Valuable comments are made during code reviews, and these should be captured against the issues to which they pertain. There's also a testing issue here (for example, do you need to > supply tests? if so, which framework or just unit tests). This > is somewhat tied into: > > * What kind of testing do we need? Every test should have a unit test. JUnit has served me well over the years. Every patch should have an attached unit test to prove out the patch. Both the patch and the unit test must be reviewed. A bug in the unit test is sometimes worse than a bug in the patch ! It would probably be easier to tackle these (dev process and > testing process) separately.... but if they spill into one another, > than so be it. > > So, regarding development process -- what do you think? > In looking around, I didn't see a norm for things (for example, > not sure if projects use JIRA for everything). We've used code > reviews inside our group at Sun for the starter kit, and it's proved > immensely valuable. I'd vote to continue it - both as a quality > measure as well as a way to get more people involved and > knowledgeable about the different pieces of code. If I was to offer my advice, I'd say keep the committer pool fairly small and allow submissions in the form of a patch. A committer will then pick up the patch and review the change, and perhaps communicate with the patch author regarding any pertinent details. Committer applies patch to the code base after reviews are complete. Hope it helps..... --Jools
