Thanks Fred for the review,
Fred Oliver (JIRA) wrote:
[ https://issues.apache.org/jira/browse/RIVER-5?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12563336#action_12563336 ]
Fred Oliver commented on RIVER-5:
---------------------------------
First, the parseURL() method has the same bug. I would prefer that method be
fixed as well.
I don't see the bug in parseURL, there is a test for the mandatory '='
character that separates the digest algorithm from the digest value. The
comment is looked for relative from the '=' character.
Second, the fix in the patch treats the '=' characters as optional instead of
required. I would prefer that the method explicitly return false if the '='
characters are missing from either string, or not located at the same index.
You are right, will do that.
--
Mark
