Thanks for the feedback Bob,
Bob Scheifler wrote:
Mark Brouwer wrote:
Attached you will find a patch against the trunk for
com.sun.jini.tool.ClassDep that contains the aggregated code changes for
the issues RIVER-7, RIVER-8 and RIVER-151.
(I didn't try to run the code.)
I'm a little confused about the lack of trailing file separator in
[in,out]sideRoots. It looks like -inroot a.foo will cause matches with
a.foobar.C for example, is that what you intended, or am I misreading
the code?
This is not what I consider right, you found a bug. I think (it has been
a while) I took the prune argument as a starting point and overlooked
that the end result can make the above happen, I'll fix it.
It seems desirable to add explicit checking and failure if the
user supplies mixed new/old options.
In the past I decided that the inroot and outroot options were silently
ignored when not in new mode, but I like failing as well here so I'll
change that.
A few suggested wording changes:
Thanks for the corrections.
--
Mark
