Peter Jones wrote:
I finally uncovered an old (early 2001) email that was the code review request for the change which added PreferredClassLoader's extra retrieval of the first JAR file without using the "jar:" URL handler-- but the explanation it contains does not make sense to me. I'm now inclined to think that we should just remove the extra retrieval, simplifying this rather confusing code (and obviating the original need for the RIVER-9 change).
Hi Peter, Bob, Sorry for the late response (was on holidays for while) and I'm having a lot of problems lately with regard to my cheiron.org mail adres. I would like to leave the code as it is for now. If the 'intriging' code is really not necessary it would be a good thing to simplify, but one could argue whether the spec for the JarURLConnection methods that throw IOException is enough to assume FileNotFoundException will be thrown in case a connection can be established and it can be determined the file doesn't exist. The implementations might seem to do the right thing, but as they don't specify when FileNotFoundException is thrown I think there is also no harm in the way the current codebase deals with it. One might create an issue for this, however. Regards, -- Mark Brouwer
