Hi Tom

Sorry, I intended the build.properties file to be in the patch ... Let me
find out what went wrong.

Best
Jonathan

2009/3/26 Tom Hobbs (JIRA) <[email protected]>

>
>    [
> https://issues.apache.org/jira/browse/RIVER-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12689670#action_12689670]
>
> Tom Hobbs commented on RIVER-301:
> ---------------------------------
>
> Hi Jonathan,
>
> Thanks for this patch, it looks a lot more robust than my effort!
>
> I've just done a fresh check-out and applied your patch to test it.
>  Following your instructions though, there is no mention of creating a
> build.properties file.  Should there be, or is it missing from the patch, or
> have I had another brain malfunction and not managed to check that file out?
>
> The lack of build.propeties is obviously limiting the amount of testing I
> can do.  :-)
>
> Cheers,
>
> Tom
>
> > Move the tests into the JUnit framework inside the main source project
> > ----------------------------------------------------------------------
> >
> >                 Key: RIVER-301
> >                 URL: https://issues.apache.org/jira/browse/RIVER-301
> >             Project: River
> >          Issue Type: Task
> >          Components: other
> >    Affects Versions: AR3
> >            Reporter: Tom Hobbs
> >         Attachments: integrationtest.xml, RIVER-301.patch,
> RIVER-301.patch, River-301.patch.zip, River-build-qa4.patch
> >
> >   Original Estimate: 672h
> >  Remaining Estimate: 672h
> >
> > The tests donated by SUN live in their own source project and are
> runnable in a format that is unfriendly towards IDEs and new developers to
> the River project.
> > This is the proposal to move the test code, mostly unmodified, into the
> main source directory whilst shoe-horning it into JUnit 3.  This will allow
> it to be easily viewable and runnable.  Such a structure will also reduce
> the code-compile-test cycle since no JARs will have to be created in the
> middle of the cycle and no long command-line incantations.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

Reply via email to