I think there was a question raised about JUnit 3 vs. 4. Could we go with 4? 3 was released a LONG time ago and the old syntax still works in 4 so it shouldn't be a big issue. We've already agreed to switch to Java 5 so that isn't an impediment. -jeff
On Wed, Apr 29, 2009 at 4:15 PM, Tom hobbs <[email protected]> wrote: > Great, I'm glad it works. (Phew). > > Sorry about the code header, I knew about it but just forgot to add it in > all my excitement. > > As you can probably see by now, I've just applied a patch and supplied a > unit test. With the unit test there is now a dependency on; > > - JUnit 3 > - Easy Mock 2.4 > - Easy Mock Class Extensions 2.4 > - CGLIB (No Dependencies) 2.2 > > What is the best way (or should I even do it?) of getting these JARs > committed/uploaded so the build scripts can use them? > > As far as I'm concerned I have no particular version preference of the > above dependencies, those just happened to be the ones I already had > downloaded. I'm having to change the code to suit other versions as people > see fit. > > Cheers, > > Tom > > > > > On Wed, 29 Apr 2009 21:06:46 -0000, Jukka Zitting <[email protected]> > wrote: > > Hi, >> >> On Wed, Apr 29, 2009 at 9:59 PM, <[email protected]> wrote: >> >>> Log: >>> Placeholder for unit test for River-283. >>> Also trying to validate I have my SVNKit setup properly in eclipse. >>> >> >> Seems to work fine, including the correct svn:eol-style setting. >> >> One comment though... >> >> --- >>> incubator/river/jtsk/trunk/test/com/sun/jini/outrigger/TxnTableTest.java >>> (added) >>> +++ >>> incubator/river/jtsk/trunk/test/com/sun/jini/outrigger/TxnTableTest.java Wed >>> Apr 29 19:59:44 2009 >>> @@ -0,0 +1,16 @@ >>> +package com.sun.jini.outrigger; >>> +[...] >>> >> >> All our source files should start with the following Apache license >> header: >> >> /* >> * Licensed to the Apache Software Foundation (ASF) under one >> * or more contributor license agreements. See the NOTICE file >> * distributed with this work for additional information >> * regarding copyright ownership. The ASF licenses this file >> * to you under the Apache License, Version 2.0 (the >> * "License"); you may not use this file except in compliance >> * with the License. You may obtain a copy of the License at >> * >> * http://www.apache.org/licenses/LICENSE-2.0 >> * >> * Unless required by applicable law or agreed to in writing, software >> * distributed under the License is distributed on an "AS IS" BASIS, >> * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or >> implied. >> * See the License for the specific language governing permissions and >> * limitations under the License. >> */ >> >> See http://www.apache.org/legal/src-headers.html for more background. >> >> BR, >> >> Jukka Zitting >> > > > > -- > Using Opera's revolutionary e-mail client: http://www.opera.com/mail/ >
