On May 25, 2010, at 812AM, Patrick Wright wrote: >>> Yes, we can use an Entry, or as Chris pointed out, if we annotate >>> MarshalledInstance's using a new Maven URL schema we can extract that info >>> and make it available via MarshalledServiceItem (An abstract class that >>> extends ServiceItem). >> >> I dont think a new Maven URL schema has actually been proposed? Why wouldnt >> we just use a String attribute in an Entry that is of the form >> groupId:artifactId:version:classifier? > > What I don't like about this is that it makes the client a little more > fragile--we would essentially be sniffing a string for a certain > format, which, if it matched, would indicate it is a Maven coordinate. > If this is in a separate type of Entry (e.g. CoordinateArtifactEntry > or so) then we are reacting to a type of entry, not to a format which > needs to be documented, etc.
Okay, I agree with you here. This also means the we dont need to refactor MarshalledInstance right? If not then we may need another entry type, one for non-maven artifacts as well. Also lets remember that for maven resolution, I think you'll also want to either provide support for parsing your maven settings.xml or include the repositories to go find the artifact if it's not present. If we dont do this then we need to include some wiring to include the repository location(s) that the primary artifact can be resolved from in the entry as well.
