Here's a voice of possibly non-relevant experience. At CXF, we have a standard format, and we include in the tree all the fixing needed to configure eclipse for that format. And we configure checkstyle to fail the build for deviations from the format. This certainly avoids all controversy about the format. All contributors are assimilated.
Now, assuming that the River project wants to aim at a similar state of affairs, how to get there? A little at a time, or with gusto? If you want to turn on checkstyle and get value out of it, you need to indeed reformat. You can put //CHECKSTYLE:OFF on everything and remove it as things get reformatted to achieve an incremental result, but then you're not getting much value in my opinion. Keep in mind that I'm a card-carrying Bolshie when it comes to this sort of thing. What I'd do is agree the checkstyle/format criteria, then freeze the tree, and use eclipse 'CleanUp' to reformat the universe, check in, and get on with life. But that's me. --benson On Sun, Dec 12, 2010 at 3:03 PM, Sim IJskes - QCG <s...@qcg.nl> wrote: > On 12/12/2010 06:37 PM, Greg Trasuk wrote: >> >> Suggestion: >> >> ## Older sources >> We do not actively search and reformat source files >> that are not formatted according to this convention. >> >> When a coder edits an older source file some reason (e.g. bug fixes or >> feature additions), he/she should reformat the file according to these >> specs. He/she should commit the reformatting separately, so as to >> separate reformatting changes from actual code changes. > > I've reread the thread, and i have to agree with Christopher. > > Reformatting a whole class in order to fix a small bug, doesn't feel right. > I would just reformat the method or just around the bug. > > When we limit ourselfs to a small reformat footprint, a inbetween commit > doesn't add that much. At least IMHO. > > I'm begging for wisdom here. Maybe we should write: > > "If the reformatting involves a large part of the code, a clearly labeled > 'reformatting' commit in between is recommended. Keeping your reformatting > changes limited, reduces the change of merging conflicts by your fellow > committers." > > Did i find the right words? > > Gr. Sim >
