On Sun, 17 Jul 2005 10:05:13 +0200, David N. Welton wrote
> János Holányi wrote:
> > On Fri, 15 Jul 2005 22:56:48 +0200, David N. Welton wrote
> > 
> >>János Holányi wrote:

> Err... I'm not clear on what you would copy where...?

Ah, forget that. Sorry, that was an earlier stage when I was investigating why
rivet didn't work on apache-ssl and I created /usr/lib/apache-ssl/1.3 and
moved the rivet mod files over there ;)

What do you think the best way to enable apache-ssl support in the rivet
package is? Shipping modules within and detect&configure both servers
accordingly (the available ones) or creating a different package (rivet-ssl)?

Let's discuss this over and I'll try to send you a patch for the final solution.

> > Let me grab the opportunity to suggest an important change to rivet/init.tcl
> > I'd be curious what you think about it:
> > 
> > --- rivet-0.5.0/rivet/init.tcl      2004-02-24 11:24:32.000000000 +0100
> > +++ /usr/lib/rivet0.5.0/init.tcl    2005-07-17 09:14:39.363021232 +0200
> > @@ -44,11 +44,11 @@
> >     global errorInfo
> >     global errorOutbuf
> >  
> > -   puts <PRE>
> > -   puts "<HR>$errorInfo<HR>"
> > -   puts "<P><B>OUTPUT BUFFER:</B></P>"
> > -   puts $errorOutbuf
> > -   puts </PRE>
> > +   set logfile /var/log/apache-ssl/rivet-error.log
> > +   puts "<pre>Error. Check log file.</pre>"
> > +   set fd [open $logfile w]
> > +   puts $fd "ERROR:\n\n$errorInfo\n---\nOUTPUT BUFFER:\n\n$errorOutbuf"
> > +   close $fd
> >      }
> 
> Could be potentially very useful... not a bad idea at all.  I don't
> think setting the log file location from in there is correct, and
> perhaps it would be best to simply take advantage of the fact that
> stderr goes to Apache's own error.log?
> 
> Other opinions?

Well - if I may ;) - logging to Apache's own error.log is also good.

There could also be a Rivet global and per virtual host directive to set the
error log file name to, which would default to empty (which in turn would log
to the Apache error.log).

By the way, are you planning to support apache2 in the near future?

Best,
Csani

--
Debian Project (http://www.debian.org/)


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to