These are the patches addressing the issues about which
I wrote last week. I added 2 patches for apache-1: one
to delete an interpreter before the child process
exits and the second to take rivetWWW.c away from
mod_rivet.c linking.
(the docs should be updated for those commands for 
which a 'package require Rivet' is needed to load 
them into the interp).

configure.ac, Makefile.am src/Makefile.am: 
a new macro 'rivet_target_dir' allows to specify 
where the Tcl stuff has to be installed. 
When not specified the variable defined by this 
macro defaults to 
${apache_base}/lib/rivet${PACKAGE_VERSION}.

src/apache-2/mod_rivet.c: during the per-interpreter 
initialization 'init.tcl' is run by calling 
Tcl_EvalFile on it.
The path to init.tcl is obtained from RIVETLIB_DESTDIR,
whose definition is in Makefile.am. I also changed
src/Makefile.am to reflect this. RIVETLIB_DESTDIR
is defined by substitution of the variable
RIVET_TCL_TARGET (see macro rivet_target_dir in 
configure.ac). Perhaps it's suboptimal, but I only
recently started to write m4 macros for the autotools.
The exit handler was re-enabled and Tcl_DeleteInterp 
called upon child exit.

apache-2/TclWebapache.c: A bug (?) caused children to 
crash when dir_module was called to look up 'index.rvt'
(or whatever else) in DirectoryIndex. 
It turned out that in this specific case the envvars 
table has a (key,value) pair where key is a valid string 
pointer, while the corresponding value is NULL. 
Fixed this by extending the check on both fields.
 
issues that need to be addressed: 

1 - make uninstall has no method that complements 
'install-data-local' during the uninstallation phase. 
In other words we can have this things installed 
everywhere but they have to be removed manually. 

2 - The env variables DATE_GMT and DATE_LOCAL carry 
wrong data. These fields are returned by ap_ht_time. 
I couldn't find a corresponding apreq2 function 
(Valery can you help?)

waiting for the usual comments and inevitable
criticism. Thank you for your patience.

 -- Massimo

--
Universita' degli Studi di Parma (http://www.unipr.it)

Attachment: configure_ac.diff
Description: Binary data

Attachment: Makefile_am.diff
Description: Binary data

Attachment: src_apache-1_mod_rivet_c.diff
Description: Binary data

Attachment: src_apache-2_mod_rivet_c.diff
Description: Binary data

Attachment: src_apache-2_TclWebapache_c.diff
Description: Binary data

Attachment: src_Makefile_am.diff
Description: Binary data

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to