Thanks Harald for profiling the Tcl stuff in 'packages', I haven't looked into every specific issue brought up by Komodo, but after a quick look it seems they're mostly suggestions for strengthening the code, hence I think it's good if you we get along what the Tcl programming oracle says. If you want to go ahead and provide the patches I will then apply and commit them with pleasure. If you want to share the work of making the changes just allow a few more days until I'm done with other stuff that needs me, just make a work plan and let me know.
cheers -- Massimo On Thu, 2012-02-09 at 18:16 +0000, bugzi...@apache.org wrote: > https://issues.apache.org/bugzilla/show_bug.cgi?id=52633 > > Bug #: 52633 > Summary: simpledb puts "...". tcl error > Product: Rivet > Version: unspecified > Platform: All > OS/Version: All > Status: NEW > Severity: minor > Priority: P2 > Component: Rivet > AssignedTo: rivet-dev@tcl.apache.org > ReportedBy: harald.oehlm...@elmicron.de > Classification: Unclassified > > > I scanned the packages within Rivet using Komodo and the syntax checker > reported the following errors and remarks: > File |Type |Line|Remark > simpledb.tcl |Error |301 |Point after closing quote > simpledb.tcl |Warning|200 |Variable "props" unknown > simpledb.tcl |Warning|202 |Variable "props" unknown > simpledb.tcl |Warning|240 |Avoid nesting of expr (1) > tclrivet.tcl |Warning|24 |Proc ||include redefined > tclrivetparser.tcl|Error |106 |extra character after closed brace (2) > tclrivetparser.tcl|Error |112 |missing " (3) > cookie.tcl |Warning|40 |Use {} to avoid double substitution (4) > cookie.tcl |Warning|41 |Use {} to avoid double substitution (5) > cookie.tcl |Warning|45 |Use {} to avoid double substitution (6) > html.tcl |Warning|20 |Use {} to avoid double substitution (7) > import_key_value_pairs.tcl > |Warning|37 |Use {} to avoid double substitution (8) > import_switch_args.tcl > |Warning|22 |Undefined variable "args" > |Warning|26 |Use {} to avoid double substitution (9) > lassign.tcl |Warning|11 |Redefines proc (10) > lempty |Warning|13 |Use {} to avoid double substitution (11) > [...] --------------------------------------------------------------------- To unsubscribe, e-mail: rivet-dev-unsubscr...@tcl.apache.org For additional commands, e-mail: rivet-dev-h...@tcl.apache.org
