The first thing I see is that we need to set some of the defaults. We have some duplicating going on that can be cleaned up.
Examples: ErrorScript should default to ::Rivet::handle_error AfterEveryScript should default to ::Rivet::cleanup_request Rather than looking for those scripts and then using the ::Rivet defaults when we don’t find out, we should just default those values in the module, and then we don’t have to do any of that dance. The only breaking change is that ::Rivet::cleanup_request is currently called on every request even if AfterEverScript has been specified. This would call for only one, which breaks backward compatibility, but I don’t think in a really significant way. Most everyone should be using AfterEveryScript instead of the older way of redefining procs anyway. It looks like we’re going to call this Rivet 3.0, so now is the time to reevaluate some old decisions and make changes. I don’t think this is a big one or that controversial. I could be shouted down if someone cared enough though. :) D > On Nov 12, 2016, at 11:52 AM, Massimo Manghi <man...@biol.unipr.it> wrote: > > now the code its ready. You need to recreate an init.tcl script by running > ./configure with the appropriate arguments. The key switch is > > ./configure ... --with-rivet-core=mod_rivet_ng > > the Tcl stuff in init.tcl.in pertaining only mod_rivet_ng is comprised > between the lines > > ######## mod_rivet_ng specific ++++++++ > > ..... > > ######## mod_rivet_ng specific -------- > > everything else is untouched therefore it should be compatible also with the > traditional default core module > > I'm looking forward to read you comments > > cheers > > -- Massimo > > > > On 11/12/2016 06:34 PM, Damon Courtney wrote: >> Sure thing. >> >> --------------------------------------------------------------------- To unsubscribe, e-mail: rivet-dev-unsubscr...@tcl.apache.org For additional commands, e-mail: rivet-dev-h...@tcl.apache.org
