On 11/21/18 11:39 AM, Massimo Manghi wrote: > On 11/21/18 10:53 AM, Ronnie Brunner wrote: >> Hi Massimo >> >> Both test suites run flawlessly on my system. >> >> My only concern would be whether we should introduce a potential >> incompatibility in a patch version or whether this justifies a minor >> version upgrade... I'm torn, it seems a border case and I can live >> with both as long as it was a conscious decision on your side and not >> just by accident. >> >> Gruess Ronnie >> >
I tried to answer Ronnie's remarks yesterday and I think I confirmed indirectly his concerns: the proposed upgrade fixes a bug, but in principle can break code that could be working on a misused call to ::rivet::var_qs or ::rivet::var_post. I'd like to have more opinions, I guess it shouldn't be an issue to roll back the 3.0 branch to 3.0.3 after the fix is saved in a patch to be applied to a new 3.1 -- Massimo
