Am 09.06.2022 um 15:37 schrieb Massimo Manghi:
On 09/06/22 14:00, Harald Oehlmann wrote:

Am 09.06.2022 um 12:37 schrieb Massimo Manghi:
Rivet 3.2.2 rc1 is available from

http://www.rivetweb.org/~manghi/rivet/rivet-3.2.2rc1.tar.gz

New features and bug fixes

  + a memory leak was fixed in Rivet_Var (src/mod_rivet_ng/rivetCore.c)

  + Installation and TEA scripts were updated

  + The form [::rivet::var all] accepts an optional flat list argument of key-value pairs which are defaults for an application query variables (yes, this argument must be interpreted as a dictionary). This form generalizes the [::rivet::var get <varname> <default>] form.

  + Tests for this new form were added and also ::rivet::var tests in general were improved

  + Configuration directive HonorHeaderOnlyReqs, though still supported, was renamed as HonorHeadRequests. Speaking the HTTP related parlance I think this a better wording of this directive (suggestions? Like dropping support for this directive and honor HTTP head requests every time?)

Dear Massimo,

thank you for the great and detail work.
I am in favor of all those changes.

My thought about the head request: head requests are standard for http since the beginning. I would just honor them always. They are part of http and should be supported in a standard way.

Thank you,
Harald



The switch has been around ever since and it's only function is to force mod_rivet to return a "text/html" message avoiding actual script execution.

     if (private->r->header_only &&
        !private->running_conf->honor_head_requests)
     {
         TclWeb_SetHeaderType(DEFAULT_HEADER_TYPE, private->req);
         TclWeb_PrintHeaders(private->req);
         retval = OK;
         goto sendcleanup;
     }


Thus no meaningful information is returned if HonorHeadRequests is false (default)

  -- Massimo

I would call that a bug. Head should be handled correctly.

Thank you for caring,
Harald


--
ELMICRON Dr. Harald Oehlmann GmbH
Koesener Str. 85
06618 NAUMBURG - Germany
Phone: +49 3445 781120
Direct: +49 3445 781127
www.Elmicron.de
German legal references:
Geschaeftsfuehrer: Dr. Harald Oehlmann
UST Nr. / VAT ID No.: DE206105272
HRB 212803 Stendal

---------------------------------------------------------------------
To unsubscribe, e-mail: rivet-dev-unsubscr...@tcl.apache.org
For additional commands, e-mail: rivet-dev-h...@tcl.apache.org

Reply via email to