Hi list,
I'd like to start a discussion (if not already started) about two specific
changes in the behaviour of the plugin interfaces I came up with.
1. Given that we now have a useful "Run again" link in the HTML output, I
wondered whether the plugin window remaining open after clicking OK is still
necessary since there's no more risk of losing your settings (as long as you
don't flush the output). As a personal experience, I always forgot to close
them, ending up with several windows which I didn't need anymore. I think that
introducing this minor change could be a noticeable improvement in the plugins
usability. Of course, I don't expect that everybody agree with me, but this
change has made my life a lot easier :-b. The patch I used also fixes a bug
that - for me - prevented the "Run again" link to show up underneath a
graphical output (I had to refresh it in order to see it).
2. The second suggestion is not to show the code by default. This is more
personal taste, but I prefer clicking to see the code when I really want to.
Besides, the default height of the code widget (40 pixels) looks so narrow
with my resolution (1280x800) that I must expand it to be able to see some of
the lines (of course it's always possible to configure that value in the
settings).
So... what do you think?
I've produced a patch for each suggestion. Hope they don't break anything, but
if they do, or are badly written, there's the idea, and I'm sure Thomas will
manage to commit these changes correctly if they're approved. :)
Best regards,
--
Mancho
Index: rkward/rkward/plugin/rkstandardcomponentgui.cpp
===================================================================
--- rkward/rkward/plugin/rkstandardcomponentgui.cpp (revisión: 2644)
+++ rkward/rkward/plugin/rkstandardcomponentgui.cpp (copia de trabajo)
@@ -156,10 +156,7 @@
command.append (code_property->printout ());
command.append ("})\n");
- RKGlobals::rInterface ()->issueCommand (new RCommand (command, RCommand::Plugin | RCommand::DirectToOutput | RCommand::ObjectListUpdate), component->commandChain ());
-
// re-run link
- command.clear ();
RKComponentHandle *handle = component->getHandle ();
if (handle->isAccessible ()) {
command.append ("\n.rk.rerun.plugin.link(plugin=\"" + RKComponentMap::getComponentId (handle) + "\", settings=\"" + RKCommonFunctions::escape (component->serializeState ()) + "\", label=\"" + i18n ("Run again") + "\")\n");
@@ -167,7 +164,13 @@
}
// separator line
command.append (".rk.make.hr()\n");
+
RKGlobals::rInterface ()->issueCommand (new RCommand (command, RCommand::Plugin | RCommand::DirectToOutput | RCommand::ObjectListUpdate), component->commandChain ());
+
+ hide ();
+ if (!enslaved) {
+ component->deleteLater ();
+ }
}
void RKStandardComponentGUI::cancel () {
Index: rkward/rkward/settings/rksettingsmoduleplugins.cpp
===================================================================
--- rkward/rkward/settings/rksettingsmoduleplugins.cpp (revisión: 2644)
+++ rkward/rkward/settings/rksettingsmoduleplugins.cpp (copia de trabajo)
@@ -176,7 +176,7 @@
}
interface_pref = static_cast<PluginPrefs> (cg.readEntry ("Interface Preferences", static_cast<int> (PreferRecommended)));
- show_code = cg.readEntry ("Code display default", true);
+ show_code = cg.readEntry ("Code display default", false);
code_size = cg.readEntry ("Code display size", 40);
}
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
RKWard-devel mailing list
RKWard-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/rkward-devel
