hi, am Sonntag 31 Oktober 2010 (11:38) schrieb Thomas Friedrichsmeier: > I did have a look at the SVN commit diffs, and that looks good to me.
fine :-) > Warning: ./man/rktest.replaceRunAgainLink.Rd:20: unexpected '}' solved that. it was just a glitch in the source file. > It is probably a good idea to (try to) keep the globalenv() as clean as > possible. So you could move that environment to the rkwardtests- > package/namespace itself. That could also simplify the code a tiny bit, as > you could create the environment unconditionally, once, and leave it in > place, even when it is empty. ok, done that. as a convenience, i also exported the function rktest.getTempDir(), so it's very easy to find the temp folder where the results were saved to. i spent some time on adding setwd() calls to a lot of tests, using rktest.getTempDir(). if i haven't overlooked something all tests should now create their special files and/or graphs only in the temp dir as well, so by calling a test the standards dir is entirely left untouched. now i wonder if this could be better solved if it was part of the tests functions somehow, though. > I did not test the latest version, yet, but interim versions worked fine > for me. A few tests fail due to using internals of the old implementation, > such as misusing rktest-functions as "data" (the "package_skeleton"-test > for example). Perhaps you could take a look at those, too? i worked around most errors i could find. but i have no clue how to deal with the errors i get by "import_spss" and "import_stata": <error> Error in read.spss("../import_export_plugins_testfile.sav", to.data.frame = TRUE, : error reading system-file header Calls: local ... eval.parent -> eval -> eval -> eval -> eval -> read.spss -> .Call In addition: Warning message: In read.spss("../import_export_plugins_testfile.sav", to.data.frame = TRUE, : ../import_export_plugins_testfile.sav: position 1: Variable name begins with invalid character Error in HTML(x, file = htmlfile, ...) : object 'my.spss.data' not found </error> and <error> Error in make.names(attr(data, \"names\")[i]) : invalid multibyte string 1 Calls: local ... eval.parent -> eval -> eval -> eval -> eval -> make.names Error in HTML(x, file = htmlfile, ...) : object 'my.stata.data' not found </error> the same happens when i try to read the file manually with those options. somebody please have a look at the "dotchart" test in "plots.R". i get an error caused by the second plot call: <error> Error in plot.xy(xy.coords(x, y), type = type, ...) : invalid plot type </error> last but not least, an error from "plot_history_basics" in "rkward_application_tests.R": <error> Error : rk.record.plot$sP.length == 6 is not TRUE </error> > > i also took care of one TODO i found in the code comments -- if a > > test was skipped due to missing packages, the results should list only > > the *missing* libs now. btw. this works perfectly here -- and it seems the previous hardcoded list of needed packages was outdated anyway, wasn't it? viele grüße :: m.eik -- dipl. psych. meik michalke institut f"ur experimentelle psychologie abt. f"ur diagnostik und differentielle psychologie heinrich-heine-universit"at 40225 d"usseldorf
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------ Nokia and AT&T present the 2010 Calling All Innovators-North America contest Create new apps & games for the Nokia N8 for consumers in U.S. and Canada $10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store http://p.sf.net/sfu/nokia-dev2dev
_______________________________________________ RKWard-devel mailing list RKWard-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/rkward-devel