pekka.klarck commented on revision r3243 in project robotframework.
Details are at http://code.google.com/p/robotframework/source/detail?r=3243
Score: Positive
General Comment:
Looks good. Some nitpick comments below.
Line-by-line comments:
File: /trunk/atest/robot/running/ProcessManager.py (r3243)
===============================================================================
Line 12: self._output_read = False
-------------------------------------------------------------------------------
This flag isn't necessarily needed. `subprocess.Popen` has returncode
attribute that is None when the process hasn't terminated so it could be
used here instead.
Line 50: self._stdout,self._stderr = self._process.communicate()
-------------------------------------------------------------------------------
Space missing after comma.
Respond to these comments at
http://code.google.com/p/robotframework/source/detail?r=3243
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
