pekka.klarck commented on revision r3780 in project robotframework.
Details are at http://code.google.com/p/robotframework/source/detail?r=3780
Score: Positive
General Comment:
Looks fine but `_extend_from_third_position` can probably be removed. See
the line-by-line comments for details on how.
Line-by-line comments:
File: /trunk/src/robot/parsing/settings.py (r3780)
===============================================================================
Line 72: def _extend_from_third_position(self, ret, tail):
-------------------------------------------------------------------------------
Is this slightly complicated helper really needed? See comments below for
ideas how to remove the need for it.
Line 128: if self.name:
-------------------------------------------------------------------------------
If this would be `if self.name or self.args`, then the body of the next
`if` could be just `ret.extend(self.args)` and
`_extend_from_third_position` would not be needed.
Line 152: if self.value:
-------------------------------------------------------------------------------
Here we could have `if self.value or self.message` and then
`_extend_from_third_position` wouldn't be needed in the next `if` either.
Respond to these comments at
http://code.google.com/p/robotframework/source/detail?r=3780
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
