[robotframework] push by pekka.klarck - Screenshot w/ IPY: Save image even if taking screenshot failed.... on 2012-09-18 10:24 GMT

Tue, 18 Sep 2012 03:24:49 -0700 

Revision: e5f9ff42eaed
Branch:   default
Author:   Pekka Klärck
Date:     Tue Sep 18 03:24:27 2012
Log:      Screenshot w/ IPY: Save image even if taking screenshot failed.

Update issue 1225
Changed behavior so that now image is saved even if taking screenshot fails. This ought to make atests pass on CI where that happens because there is no display.
This is an ugly solution to make those tests pass, but then again JVM also gives us black images, and no exception, if there is no display. 
http://code.google.com/p/robotframework/source/detail?r=e5f9ff42eaed

Modified:
 /src/robot/libraries/Screenshot.py

=======================================
--- /src/robot/libraries/Screenshot.py  Fri Sep 14 03:43:57 2012
+++ /src/robot/libraries/Screenshot.py  Tue Sep 18 03:24:27 2012
@@ -305,7 +305,7 @@
             graphics.CopyFromScreen(0, 0, 0, 0, bmp.Size)
         finally:
             graphics.Dispose()
-        bmp.Save(path, Imaging.ImageFormat.Jpeg)
+            bmp.Save(path, Imaging.ImageFormat.Jpeg)

     def _wx_screenshot(self, path):
         context = wx.ScreenDC()

Reply via email to