Comment by pekka.klarck:
Score: Neutral
General Comment:
The general approach looks fine but code needs fixes and little cleanup.
Line-by-line comments:
File: /src/robot/variables/variables.py
(r88b3ece09ed895a611c241815cfd11eea83dd0ff)
===============================================================================
Line 102: iter(value)
-------------------------------------------------------------------------------
This accepts strings but they should not be accepted.
Line 104: except KeyError, TypeError:
-------------------------------------------------------------------------------
Should in general have two separate excepts closer to the statements that
can fail. This is also buggy -- should be `except (KeyError, TypeError)`
For more information:
http://code.google.com/p/robotframework/source/detail?r=88b3ece09ed895a611c241815cfd11eea83dd0ff
--
---
You received this message because you are subscribed to the Google Groups "robotframework-commit" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
