Comment #4 on issue 1481 by pekka.klarck: Wait For Process add
arguments "timeout=1m", "handleTimeout=Terminate Process"
http://code.google.com/p/robotframework/issues/detail?id=1481
@Marcin.Koperski and @frehberg: I understand that the need for custom
functionality if a process was not stopped and I appreciate the provided
patch.
The main problem implementing this is that I'd like this kind of
functionality be generic. If we implement it to this keyword, we should
then implement it to countess other keywords. That would naturally be a lot
of work and it would also complicate those keywords unnecessarily. Most
likely the usage would also be different in different keywords/libraries --
the proposed approach is already different compared to the similar
functionality in SeleniumLibraries.
My thinking is that we could change Wait For Process in RF 2.8.2 so that it
takes an optional timeout and always kills the process if the timeout
occurs. This would be easy to implement and would cover the most common
needs. Having additional options to control should the process be
terminated, killed, or left alone would be possible too, but I'd rather
leave them for later.
The main reason for me being so conservative with this is that it is always
very hard to change the arguments that a keyword accept. Adding new
arguments when the defaults are so that the old functionality does not
change is easy. The same goes also for new keywords -- we don't want to add
keywords unless we know they are really useful.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
---
You received this message because you are subscribed to the Google Groups "robotframework-commit" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to robotframework-commit+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
