Updates:
Summary: Should not use `has_key` in `Collections` or elsewhere because
general mappings do not have it
Status: Accepted
Labels: Target-2.8.2
Comment #2 on issue 1479 by pekka.klarck: Should not use `has_key` in
`Collections` or elsewhere because general mappings do not have it
http://code.google.com/p/robotframework/issues/detail?id=1479
I looked at this noticed that CaseInsensitiveDict in requests used to be
based on dict but is nowadays based on MutableMapping. I also learned that
MutableMapping and Mapping don't have has_key, only __contains__:
http://docs.python.org/2/library/collections.html#collections-abstract-base-classes
It's best that we stop using `mapping.has_key(key)` altogether in favor of
`key in mapping`. We already use the latter, more Pythonic version, in most
places so this shouldn't be a big task.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
---
You received this message because you are subscribed to the Google Groups "robotframework-commit" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
