Updates:
Status: Started
Comment #8 on issue 86 by pekka.klarck: FTP library
http://code.google.com/p/robotframework/issues/detail?id=86
@mkov80, great that you've created a library for this purpose! Have you
already advertised elsewhere too? Do you consider it stable enough to be
widely recommended and listed at http://robotframework.org? The library
doesn't need to any more "official" to be added there, we just expect
libraries there to be out of alpha/beta stage.
Some comments about the library based a very quick look:
1) I noticed that currently the library doesn't have any installer and is
installed by just putting it to PYTHONPATH. For a library distributed as a
single fine that's OK, but making the library installable with pip
<http://pip-installer.org> would be really nice. Running something like
`pip install rf-ftp` or `pip install robotframework-ftplibrary` would be a
very convenient way to install it.
2) Looking at the source I noticed the library is implemented as functions
in a module. For a library that needs a state, in this case FTP connection,
that is probably not the best approach. You are handling that state with a
global `rfftp` variable. Having a class with `rfftp` as an instance
attribute would likely be simpler. This doesn't really affect the library
usage and isn't thus that important.
3) ftp_connect() method takes some of the arguments as **kwargs, but it
could take then as normal arguments with default values. That would make
both code and documentation easier.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
---
You received this message because you are subscribed to the Google Groups "robotframework-commit" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
