Comment by pekka.klarck:
Score: Positive
Line-by-line comments:
File: /src/robot/running/arguments/argumentresolver.py
(r29386a1891fb3c29851668bf7914669a57799746)
===============================================================================
Line 20: except:
-------------------------------------------------------------------------------
Should except ImportError or import only if sys.platform.startswith('java').
Even better solution might be changing is is_dict_like to allow testing
also against map e.g. like `is_dict_like(thing, allow_java_map=True)`.
Line 47: if named:
-------------------------------------------------------------------------------
should also return False right away if not argspec.kwargs.
For more information:
http://code.google.com/p/robotframework/source/detail?r=29386a1891fb3c29851668bf7914669a57799746
--
---
You received this message because you are subscribed to the Google Groups "robotframework-commit" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to robotframework-commit+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
