2 new revisions:
Revision: a4eabb95c906
Branch: default
Author: Robot Framework Developers (robotframew...@gmail.com)
Date: Thu Feb 13 14:35:12 2014 UTC
Log: report: refactored setting/getting hash
http://code.google.com/p/robotframework/source/detail?r=a4eabb95c906
Revision: d4f12d916551
Branch: default
Author: Robot Framework Developers (robotframew...@gmail.com)
Date: Thu Feb 13 15:04:08 2014 UTC
Log: report: Fixed search using & and % on Firefox....
http://code.google.com/p/robotframework/source/detail?r=d4f12d916551
==============================================================================
Revision: a4eabb95c906
Branch: default
Author: Robot Framework Developers (robotframew...@gmail.com)
Date: Thu Feb 13 14:35:12 2014 UTC
Log: report: refactored setting/getting hash
http://code.google.com/p/robotframework/source/detail?r=a4eabb95c906
Modified:
/src/robot/htmldata/rebot/report.html
=======================================
--- /src/robot/htmldata/rebot/report.html Fri Feb 7 10:10:51 2014 UTC
+++ /src/robot/htmldata/rebot/report.html Thu Feb 13 14:35:12 2014 UTC
@@ -106,9 +106,10 @@
}
function showDetailsByHash() {
- if (window.location.hash == window.prevLocationHash)
+ var hash = window.location.hash.substring(1);
+ if (!hash || hash == window.prevLocationHash)
return;
- var parts = window.location.hash.substring(1).split('?');
+ var parts = hash.split('?');
var name = parts.shift();
var query = parts.join('?');
if (name == 'search') {
@@ -268,8 +269,7 @@
function scrollToSelector(base, query) {
$('#test-details-container').css('min-height', $(window).height());
var anchor = query ? base + '?' + encodeURIComponent(query) : base;
- window.prevLocationHash = '#' + anchor;
- window.location.hash = anchor;
+ window.location.hash = window.prevLocationHash = anchor;
}
function renderSelector(args, template, stats) {
==============================================================================
Revision: d4f12d916551
Branch: default
Author: Robot Framework Developers (robotframew...@gmail.com)
Date: Thu Feb 13 15:04:08 2014 UTC
Log: report: Fixed search using & and % on Firefox.
Update issue 1658
Status: Review
Fixed by using window.location.href.split('#') instead of
window.location.hash.substring(1) as recommended in Stack Overflow.y
http://code.google.com/p/robotframework/source/detail?r=d4f12d916551
Modified:
/src/robot/htmldata/rebot/report.html
=======================================
--- /src/robot/htmldata/rebot/report.html Thu Feb 13 14:35:12 2014 UTC
+++ /src/robot/htmldata/rebot/report.html Thu Feb 13 15:04:08 2014 UTC
@@ -106,7 +106,9 @@
}
function showDetailsByHash() {
- var hash = window.location.hash.substring(1);
+ // Cannot use window.location.hash because Firefox incorrectly decodes
it:
+ //
http://stackoverflow.com/questions/1703552/encoding-of-window-location-hash
+ var hash = window.location.href.split('#').splice(1).join('#');
if (!hash || hash == window.prevLocationHash)
return;
var parts = hash.split('?');
--
---
You received this message because you are subscribed to the Google Groups "robotframework-commit" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to robotframework-commit+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
