Revision: c87579c32168
Branch: default
Author: Jussi Malinen <[email protected]>
Date: Wed Jun 11 12:20:43 2014 UTC
Log: Update issue 1729
Fix typo in sending control character. Added an acceptance test.
http://code.google.com/p/robotframework/source/detail?r=c87579c32168
Modified:
/atest/robot/standard_libraries/telnet/read_and_write.txt
/atest/testdata/standard_libraries/telnet/read_and_write.txt
/src/robot/libraries/Telnet.py
=======================================
--- /atest/robot/standard_libraries/telnet/read_and_write.txt Fri Nov 22
11:25:00 2013 UTC
+++ /atest/robot/standard_libraries/telnet/read_and_write.txt Wed Jun 11
12:20:43 2014 UTC
@@ -30,6 +30,9 @@
Write Bare With Newlines
Check Test Case ${TEST NAME}
+
+Write control character
+ Check Test Case ${TEST NAME}
Read Until
${tc} = Check Test Case ${TEST NAME}
=======================================
--- /atest/testdata/standard_libraries/telnet/read_and_write.txt Tue Sep 17
12:23:50 2013 UTC
+++ /atest/testdata/standard_libraries/telnet/read_and_write.txt Wed Jun 11
12:20:43 2014 UTC
@@ -57,6 +57,12 @@
${out} = Read Until 1 2 3
Should Be Equal ${out} a=1\r\n${FULL PROMPT}b=2\r\n${FULL
PROMPT}echo $a $b 3\r\n1 2 3
+Write control character
+ [Documentation] FAIL STARTS: No match found for 'moi' in 300
milliseconds.
+ Write sleep 0.2;echo moi
+ Write Control Character IP
+ Read until moi
+
Read Until
Write pwd
${out} = Read Until /
=======================================
--- /src/robot/libraries/Telnet.py Wed Jun 11 11:48:14 2014 UTC
+++ /src/robot/libraries/Telnet.py Wed Jun 11 12:20:43 2014 UTC
@@ -786,7 +786,7 @@
| Write Control Character | 241 | # Send No operation command |
"""
self._verify_connection()
- self.sock.sendall(telnetlib.IAC +
self._get_control_character(code))
+ self.sock.sendall(telnetlib.IAC +
self._get_control_character(character))
def _get_control_character(self, int_or_name):
try:
--
---
You received this message because you are subscribed to the Google Groups "robotframework-commit" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
