On 17.03.2014 17:45, rock wrote: > #429: Typelib incompatible with gcc 4.8 > -----------------------+----------------------- > Reporter: stpl01 | Owner: mago02 > Type: defect | Status: accepted > Priority: major | Milestone: > Component: toolchain | Resolution: > Keywords: typelib | > -----------------------+----------------------- > > Comment (by jama01): > > Uhm, I would more vote for using ::uint64_t etc. and include stdint.h by > default. > Greetings > Janosch > I'm against this.
the inttypes are not part of c++ by default. They were inroduces by GCC 4.8. You patch is therefore not backward compatible. In general i would prefer your solution, but: - It could change the behaviour because you exchaning the boost types by other ones (unknown risk) - To solve backward compatibilty you need to add defines where you check for the GCC/glibc version --- i don't like this kind of fixed, in the long run we could change if really neraly everyone supports the baselevel inttypes. In the meantime to keep the impact as small as possible, keep the simple patch the the same types than before are used. Best, Matthias -- -- Matthias Goldhoorn Unterwasserrobotik Standort Bremen: DFKI GmbH Robotics Innovation Center Robert-Hooke-Straße 5 28359 Bremen, Germany Phone: +49 (0)421 218-64100 Fax: +49 (0)421 218-64150 E-Mail: [email protected] Weitere Informationen: http://www.dfki.de/robotik ----------------------------------------------------------------------- Deutsches Forschungszentrum fuer Kuenstliche Intelligenz GmbH Firmensitz: Trippstadter Straße 122, D-67663 Kaiserslautern Geschaeftsfuehrung: Prof. Dr. Dr. h.c. mult. Wolfgang Wahlster (Vorsitzender) Dr. Walter Olthoff Vorsitzender des Aufsichtsrats: Prof. Dr. h.c. Hans A. Aukes Amtsgericht Kaiserslautern, HRB 2313 Sitz der Gesellschaft: Kaiserslautern (HRB 2313) USt-Id.Nr.: DE 148646973 Steuernummer: 19/673/0060/3 ----------------------------------------------------------------------- _______________________________________________ Rock-dev mailing list [email protected] http://www.dfki.de/mailman/cgi-bin/listinfo/rock-dev
