Why I don't like external/ - it feels too much like "I don't know where to put it, so I put it in external/" - there is no such thing as "packages not in external are under the direct maintenance of Rock". It simply does not scale. If someone complains that slam/orogen/blabla fails, I personally don't feel obligated to fix it. If we want Rock to strive, we should make sure that people feel like they can contribute their package to the distribution *while* having maintenance of the code, just like ROS does. The only thing that is "under the direct maintenance of Rock" is rock.core. - it makes browsing the packages terrible. When I want to look at what exists for e.g. planning, I go in the planning/ category. When I look at a package in external/ I really don't know what they are for. Not even a clue. - categories are not perfect. One of Janosch's argument against box2d in simulation was "this is not a real simulation engine in the sense of physical correctness.". Fair enough. Now, so what ? It is a bad simulation engine but a simulation engine nonetheless.
Moreover, external/ is bound to become the biggest category in all of Rock... We will reuse more and more ! For instance, - external/ompl and external/sbpl should IMO go in planning/ - external/freenect and external/aruco in drivers/ - ... Sylvain On Tue, Jul 15, 2014 at 3:34 PM, Matthias Goldhoorn <[email protected]> wrote: > I still like the external/ folder too > > it makes kind of clear that these packages not directly under the > maintanance of rock. > In the first run it might confuse that they are not related to packages. but > i do like the external too. > > Best, > Matthias > > > On 15.07.2014 15:03, Janosch Machowinski wrote: > > Any opinions, > were a 2d game engine should go ? > I vote for external. > Greetings > Janosch > > > > -------- Original Message -------- > Return-Path: <[email protected]> > Received: from lnv-91186.sb.dfki.de ([unix socket]) by lnv-91186 (Cyrus > v2.3.16) with LMTPA; Tue, 15 Jul 2014 14:36:07 +0200 > X-Sieve: CMU Sieve 2.3 > Received: from mail.dfki.de (lnv-104.sb.dfki.de [134.96.191.146]) by > lnv-91186.sb.dfki.de (Postfix) with ESMTP id CE31C3937E for > <[email protected]>; Tue, 15 Jul 2014 14:36:07 +0200 (CEST) > Received: by mail.dfki.de (Postfix) id CF72331426; Tue, 15 Jul 2014 14:36:07 > +0200 (CEST) > Delivered-To: [email protected] > Received: from sea-mail.dfki.de (sea-mail.dfki.de [134.96.191.185]) by > mail.dfki.de (Postfix) with ESMTP id CA52C313BA for > <[email protected]>; Tue, 15 Jul 2014 14:36:07 +0200 (CEST) > Received: from sea-mail.dfki.de (localhost.localdomain [127.0.0.1]) by > localhost (Email Security Appliance) with SMTP id A8EF8A0E5E_3C52037B for > <[email protected]>; Tue, 15 Jul 2014 12:36:07 +0000 (GMT) > Received: from github-smtp2a-ext-cp1-prd.iad.github.net > (github-smtp2-ext4.iad.github.net [192.30.252.195]) (using TLSv1 with cipher > DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.iad.github.net", Issuer > "DigiCert SHA2 High Assurance Server CA" (verified OK)) by sea-mail.dfki.de > (Sophos Email Appliance) with ESMTPS id 46429A0E56_3C52037F for > <[email protected]>; Tue, 15 Jul 2014 12:36:07 +0000 (GMT) > Date: Tue, 15 Jul 2014 05:36:06 -0700 > From: Sylvain Joyeux <[email protected]> > Reply-To: rock-core/rock-package_set > <reply+i-37487163-09d3edf5b7d3054f4171ea166c07adfa7cebb5aa-7935...@reply.github.com> > To: rock-core/rock-package_set <[email protected]> > Cc: jmachowinski <[email protected]> > Message-ID: <rock-core/rock-package_set/pull/2/[email protected]> > In-Reply-To: <rock-core/rock-package_set/pull/[email protected]> > References: <rock-core/rock-package_set/pull/[email protected]> > Subject: Re: [rock-package_set] added Box2D library (#2) > Mime-Version: 1.0 > Content-Type: multipart/alternative; > boundary="--==_mimepart_53c5203624b79_55f63f9f450a32b84903f2"; charset=UTF-8 > Content-Transfer-Encoding: 7bit > Precedence: list > X-GitHub-Recipient: jmachowinski > X-GitHub-Reason: author > List-ID: rock-core/rock-package_set <rock-package_set.rock-core.github.com> > List-Archive: https://github.com/rock-core/rock-package_set > List-Post: > <mailto:reply+i-37487163-09d3edf5b7d3054f4171ea166c07adfa7cebb5aa-7935...@reply.github.com> > List-Unsubscribe: > <mailto:unsub+i-37487163-09d3edf5b7d3054f4171ea166c07adfa7cebb5aa-7935...@reply.github.com>, > <https://github.com/notifications/unsubscribe/7935404__eyJzY29wZSI6Ik5ld3NpZXM6TXV0ZSIsImV4cGlyZXMiOjE3MjEwNDY5NjYsImRhdGEiOnsiaWQiOjM2NjA4Mzc5fX0=--b00ddbbff481c869070552e6faa289c2a7471969> > X-Auto-Response-Suppress: All > X-GitHub-Recipient-Address: [email protected] > X-Sophos-ESA: [sea-mail.dfki.de] 3.8.0.0, Antispam-Engine: 2.7.2.1390750, > Antispam-Data: 2014.7.15.122721 > > > octomap contains GUI and GL stuff. Well, basically anything contains GUI and > GL stuff these days. > > If you google box2d, its subtitle is "2d physics engine for games". The > amount of correctness it has is IMO irrelevant, it aims at doing simulation. > > The real question is: where would you put it if Rock people developed it ? > External is a non-category, that's why I personally want to get rid of it. > > If you don't agree, we should move this discussion to rock-dev. > > — > Reply to this email directly or view it on GitHub. > > > > > > _______________________________________________ > Rock-dev mailing list > [email protected] > http://www.dfki.de/mailman/cgi-bin/listinfo/rock-dev > > > > -- > Dipl.-Inf. Matthias Goldhoorn > Space and Underwater Robotic > > Universität Bremen > FB 3 - Mathematik und Informatik > AG Robotik > Robert-Hooke-Straße 1 > 28359 Bremen, Germany > > Zentrale: +49 421 178 45-6611 > > Besuchsadresse der Nebengeschäftstelle: > Robert-Hooke-Straße 5 > 28359 Bremen, Germany > > Tel.: +49 421 178 45-4193 > Empfang: +49 421 178 45-6600 > Fax: +49 421 178 45-4150 > E-Mail: [email protected] > > Weitere Informationen: http://www.informatik.uni-bremen.de/robotik > > > _______________________________________________ > Rock-dev mailing list > [email protected] > http://www.dfki.de/mailman/cgi-bin/listinfo/rock-dev > _______________________________________________ Rock-dev mailing list [email protected] http://www.dfki.de/mailman/cgi-bin/listinfo/rock-dev
