If we were to use the git, we probably would use the latest released PCL version, which would not really help with the "did not get updated" situation. It would indeed improve the "override-ability". But by having everyone "update" privately, Rock as a whole loses.
Updates to external packages like this usually require someone to push for it, because if noone wants it, then noone will bother to check whether the new PCL version(s) have backward compatibility issues (thus breaking other people's code), and noone will bother push to get it updated. Completely hypothetically: reasons why there has not been such a push might be that 1.7.1 -> 1.7.2 does not seem as huge as you are making it sound (at least according to https://github.com/PointCloudLibrary/pcl/releases). I.e. if you had code working on 1.7.1, 1.7.2 is not a major improvement to you. And that since Ubuntu 15.04, pcl is provided by binary packaged (which are packaging 1.7.2). Ironically, the fact that 1.7.2 is mainly a bugfix release means that we could pretty easily update ... but that's up to the PCL users to push for that change (which you are doing right now, thanks !) Sylvain On Wed, Mar 16, 2016 at 6:05 AM, Martin Günther <[email protected]> wrote: > Hi all, > > On Thu, 10 Mar 2016 13:55:51 +0100 > Javier Hidalgo Carrió <[email protected]> wrote: > >> Hi, >> >> Is there any reason why Rock does not use the github repository for >> PCL? Instead we directly take the tall-bar file url: >> 'https://github.com/PointCloudLibrary/pcl/archive/pcl-1.7.1.tar.gz' >> >> Javi. > > I've been wondering the same thing; I'd also prefer if Rock used the > Git repo directly. At the moment I usually do that manually on my side, > but autoproj hates when I do that. > > I've opened a PR here: > > https://github.com/rock-core/rock-package_set/pull/109 > > While we're on it: PCL 1.7.1 is 2,5 years old, and there's been a ton > of improvements since. PCL 1.7.2 has been released 1,5 years ago, and > the PCL maintainers are preparing the 1.8.0 release at the moment; it > would be nice if we could upgrade at some point. > > Cheers, > Martin > > -- > Dipl.-Inf. Martin Günther > Researcher > > DFKI GmbH > Robotics Innovation Center Bremen - Außenstelle Osnabrück > ICO InnovationsCentrum Osnabrück GmbH > Albert-Einstein-Straße 1 > 49076 Osnabrück, Germany > _______________________________________________ > Rock-dev mailing list > [email protected] > http://www.dfki.de/mailman/cgi-bin/listinfo/rock-dev _______________________________________________ Rock-dev mailing list [email protected] http://www.dfki.de/mailman/cgi-bin/listinfo/rock-dev
