On 18/05/06, XavierGr <[EMAIL PROTECTED]
> wrote:
I see that Hristo has commited your fix.
Hristo can you look at patch #5362. It has some other minor bugfixes for the jpeg viewer.
Also it would be good to see patch for the zoom thingy (#4840)
BTW I submitted a bugfix on minesweeper (#5384). Is there a reason why I can't find it on the tracker? (I can find it only by task number)
On 18/05/06, Bill Janssen < [EMAIL PROTECTED]> wrote:On the Mac, with the simulator, the simulator doesn't exit when told to.
Turns out there's some code in uisimulator/sdl/uisdl/gui_shutdown()
which hangs waiting for a semaphore to empty, for no particularly good
reason.
The following patch fixes that behavior.
Bill
Index: uisdl.c
===================================================================
RCS file: /cvsroot/rockbox/uisimulator/sdl/uisdl.c,v
retrieving revision 1.9
diff -c -r1.9 uisdl.c
*** uisdl.c 19 Mar 2006 06:59:36 -0000 1.9
--- uisdl.c 18 May 2006 02:21:51 -0000
***************
*** 166,179 ****
{
int i;
- SDL_KillThread(gui_thread);
SDL_RemoveTimer(tick_timer_id);
for (i = 0; i < threadCount; i++)
{
SDL_KillThread(threads[i]);
}
return true;
}
--- 166,184 ----
{
int i;
SDL_RemoveTimer(tick_timer_id);
+ #ifndef __APPLE__
+
+ SDL_KillThread(gui_thread);
+
for (i = 0; i < threadCount; i++)
{
SDL_KillThread(threads[i]);
}
+ #endif
+
return true;
}
***************
*** 237,242 ****
gui_message_loop();
! return gui_shutdown();
}
--- 242,247 ----
gui_message_loop();
! return (gui_shutdown() ? 0 : 1);
}
