Just want to point out that volume should not be changed from the current 
method because some people use 'max' and 'min/mute' bitmaps, and they won't 
work right otherwise.

Battery change sounds fine though. :)

Zakk

<[EMAIL PROTECTED]>

-----Original Message-----
From: "Linus Nielsen Feltzing" <[EMAIL PROTECTED]>
To: "Rockbox development" <[email protected]>
Sent: 1/4/2007 4:18 AM
Subject: Re: Battery and volume level display in WPS

Tobias Heimann wrote:
> IMHO it would be more logical to spread the highest interval as the 
> other ones, e.g. using:
> 
>                     int l = MIN(battery_level(), 99);
>                     ...
>                     *intval = limit * l / 100 + 1 + 1;
> 
> The volume display interval has the same issue btw.

Sounds OK to me. Care to submit a patch?

Linus
.



Reply via email to