On 29/01/07, Daniel Stenberg <[EMAIL PROTECTED]> wrote:
On Sun, 28 Jan 2007, Jonathan Gordon wrote:
> The diff does not currently support making menus from just settings (this
> will come ASAP, but wanted to get this email out).
My initial reaction: I dislike how you sprinkle the code with macros that
inserts code (but hides it from the casual reader), so that it looks like
function invokes but is not. Also they hide side effects due to extra
semicolons and re-use of the macro argument in more than one place in the
macro target.
--
Daniel Stenberg -- http://www.rockbox.org/ -- http://daniel.haxx.se/
I assume you are talking about the macros in menu.h? I agree they are
bad, but without them the code would be more difficult to follow. they
should never be used in a loop, so the extra semicolons shouldn't be a
problem.
