Re: barrywardell: r12838 - trunk/firmware/common

[Magnus Holmgren]

Barry Wardell wrote:

Should it really modify the input string like that? What if it is in
flash? (Might not be a problem as currently used, but...)

   Magnus

Good point. Would this be a better way to do it:

<...>

@@ -160,7 +161,7 @@
        while (width-- > 0 && ok)
            ok=push(userp, pad);
        }
-        while (*str != '\0' && ok)
+        while (*str != '\0' && ok && precision--)
                ok=push(userp, *str++);
    }

Yes, that looks like a good solution.

  Magnus