>>I began to write a patch for button-x5.c file to filter the button
>>status (http://www.rockbox.org/tracker/task/6787) but things are not
>>that easy.

I am one of these people. I tried the patch and it did improve the stability.

I tried to improve it with various filters, but came to the conclusion that I 
needed to see the raw data and then run various filters in excel to compare 
properly.

I had the button-x5.c (attached) write the 1st 100 key presses after pressing 
select. I got some data out, but then I damaged my harddrive and am waiting to 
repair it. 
Cheers

David
ps I think I attached the right version, It was a while ago

pps
This is the vbs script I use to convert the data from hex to a csv. 


  Set objArgs = WScript.Arguments REM- Drag and drop file onto VBS

  rem- WScript.Echo objArgs(0)


  Const adTypeBinary = 1
  
  'Create Stream object
  Dim BinaryStream
  Set BinaryStream = CreateObject("ADODB.Stream")
  
  'Specify stream type - we want To get binary data.
  BinaryStream.Type = adTypeBinary
  
  'Open the stream
  BinaryStream.Open
  
  'Load the file data from disk To stream object
  BinaryStream.LoadFromFile objArgs(0)
  
  'Open the stream And get binary data from the object
  ReadBinaryFile = BinaryStream.Read


  
  Dim cl1, cl2, cl3, pl1, pl2, pl3, pl4, Num_Pixels_To_Process
  Dim L
  cl1 = 1
  cl2 = 1
  cl3 = 1
  Num_Pixels_To_Process = 256
  L = LenB(ReadBinaryFile )

  Do While cl1<=L

        pl4 = (Int(AscB(MidB(ReadBinaryFile ,cl1,1))))
    
     rem   msgbox (Int(AscB(MidB(ReadBinaryFile ,cl1,1)))) & " and " & 
(Int(AscB(MidB(ReadBinaryFile ,cl1 +1 ,1)))) & " = " & pl4 
       
    pl3 = pl3 & pl4 & ", " & vbNewLine 

'Messagebox after Num_Pixels_To_Process pixels 
    'If cl1 >= (Num_Pixels_To_Process*2) Then 
    '    msgbox "Total Pixels =" & cl1/2 & vbNewLine & "First few:" & vbNewLine 
& MidB(pl3, 1, 256) 
    '    L = 0
    'End If
    cl1 = cl1 + 1
  Loop


dim filesys, demofile, txtstream
set filesys = CreateObject ("Scripting.FileSystemObject")
set demofile = filesys.CreateTextFile (objArgs(0) & ".csv", true)
set demofile = filesys.GetFile(objArgs(0) & ".csv")
set txtstream = demofile.OpenAsTextStream (2, -2)
txtstream.Write pl3
txtstream.Close 








      ___________________________________________________________ 
Want ideas for reducing your carbon footprint? Visit Yahoo! For Good  
http://uk.promotions.yahoo.com/forgood/environment.html
/***************************************************************************
 *             __________               __   ___.
 *   Open      \______   \ ____   ____ |  | _\_ |__   _______  ___
 *   Source     |       _//  _ \_/ ___\|  |/ /| __ \ /  _ \  \/  /
 *   Jukebox    |    |   (  <_> )  \___|    < | \_\ (  <_> > <  <
 *   Firmware   |____|_  /\____/ \___  >__|_ \|___  /\____/__/\_ \
 *                     \/            \/     \/    \/            \/
 * $Id: button-x5.c 12627 2007-03-05 20:14:41Z amiconn $
 *
 * Copyright (C) 2006 by Linus Nielsen Feltzing
 *
 * All files in this archive are subject to the GNU General Public License.
 * See the file COPYING in the source tree root for full license agreement.
 *
 * This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
 * KIND, either express or implied.
 *
 ****************************************************************************/
#include <stdio.h>
#include "atoi.h"
#include "file.h"
#include <file.h>
#include <sprintf.h>
#include <string.h>


#include "config.h"
#include "system.h"
#include "button.h"
#include "backlight.h"
#include "adc.h"
#include "lcd-remote-target.h"

/* have buttons scan by default */
static bool button_scan_on     = true;
static bool hold_button        = false;
static bool remote_hold_button = false;

void button_init_device(void)
{
    /* Power, Remote Play & Hold switch */
    GPIO_FUNCTION |= 0x0e000000;
    GPIO_ENABLE &= ~0x0e000000;
}

void button_enable_scan(bool enable)
{
    button_scan_on = enable;
}

bool button_scan_enabled(void)
{
    return button_scan_on;
}

bool button_hold(void)
{
    return (GPIO_READ & 0x08000000) == 0;
}

bool remote_button_hold(void)
{
    return remote_hold_button;
}

int button_read_device(void)
{
        #define FILTER 2
    #define DELTA 1
    int  btn = BUTTON_NONE;
    bool hold_button_old;
    bool remote_hold_button_old;
    int data;
    static int data_last_valid = 0xFF;
    static int tab[FILTER] = {0xff};
    static int cursor = 0;
    int tab_size = FILTER;
    int tab_max = 0x00;
    int tab_min = 0xFF;
    int i;
    int file_sett;
    char textbuffer[100];
    static int j=0;
    static bool start=0;

    /* normal buttons */
    hold_button_old = hold_button;
    hold_button = button_hold();

#ifndef BOOTLOADER
    /* give BL notice if HB state chaged */
    if (hold_button != hold_button_old)
        backlight_hold_changed(hold_button);
#endif

    if (button_scan_on && !hold_button)
    {
        data = adc_scan(ADC_BUTTONS);

        if (j<100 && start == 1)
        {

        textbuffer[j++] = data;
       if (j==99)
       {
       file_sett=open("/button_Presses.txt", O_RDWR | O_CREAT);
                        if (file_sett >= 0)
                        {
                   write(file_sett, textbuffer, 100);
                        close(file_sett);
                          }

        }
            }
         /* ADC debouncing */
        tab[cursor++] = data;
        if (cursor >= tab_size)
                cursor = 0;
        for (i = 0; i < tab_size; i++)
        {
            if ((unsigned) tab[i] < (unsigned) tab_min)
                tab_min = tab[i];
            if ((unsigned) tab[i] > (unsigned) tab_max)
                tab_max = tab[i];
        }
        if ((unsigned) tab_max - (unsigned) tab_min <= DELTA)
        {
            data = tab_min;
            data_last_valid = tab_min;
                }
       else
            data = data_last_valid;

                if (data >= 0xf0 && cursor == 0)                        //Reset 
FILTER as no button was pressed
                        {
                        for (i = 0; i < tab_size; i++)
                            tab[i] = 0xff;
                        data_last_valid = 0xff;
                     }

        if (data < 0xf0)
        {
            if(data < 0x7c)
                if(data < 0x42)
                    btn = BUTTON_LEFT;
                else
                    if(data < 0x62)
                        btn = BUTTON_RIGHT;
                    else
                    {
                        btn = BUTTON_SELECT;
                        start = 1;
                                        }
            else
                if(data < 0xb6)
                    if(data < 0x98)
                        btn = BUTTON_REC;
                    else
                        btn = BUTTON_PLAY;
                else
                    if(data < 0xd3)
                        btn = BUTTON_DOWN;
                    else
                        btn = BUTTON_UP;
        }
    }

    /* remote buttons */
    data = remote_detect() ? adc_scan(ADC_REMOTE) : 0xff;

    remote_hold_button_old = remote_hold_button;
    remote_hold_button = data < 0x17;

#ifndef BOOTLOADER
    if (remote_hold_button != remote_hold_button_old)
        remote_backlight_hold_changed(remote_hold_button);
#endif

    if (!remote_hold_button)
    {
        if (data < 0xee)
        {
            if(data < 0x7a)
                if(data < 0x41)
                    btn |= BUTTON_RC_FF;
                else
                    if(data < 0x61)
                        btn |= BUTTON_RC_REW;
                    else
                        btn |= BUTTON_RC_MODE;
            else
                if(data < 0xb4)
                    if(data < 0x96)
                        btn |= BUTTON_RC_REC;
                    else
                        btn |= BUTTON_RC_MENU;
                else
                    if(data < 0xd1)
                        btn |= BUTTON_RC_VOL_UP;
                    else
                        btn |= BUTTON_RC_VOL_DOWN;
        }
    }

    data = GPIO_READ;

    /* hold and power are mutually exclusive */
    if (!(data & 0x04000000))
        btn |= BUTTON_POWER;

    /* remote play button should be dead if hold */
    if (!remote_hold_button && !(data & 0x02000000))
        btn |= BUTTON_RC_PLAY;

    return btn;
}

Reply via email to