On Sun, Nov 09, 2008, Frank Gevaerts wrote: > On Sun, Nov 09, 2008 at 07:17:14AM +0100, [EMAIL PROTECTED] wrote: > > Date: 2008-11-09 07:17:14 +0100 (Sun, 09 Nov 2008) > > New Revision: 19043 > > > > Log Message: > > SD PP: move non specific defines to sd.h, to be reused by other SD drivers > > Good idea, but since sd.h is (inderectly) included in not directly > related code, I think the defines should be prefixed with SD_
That's better to use a SD_ namespace, I will correct that and also look at using these defines in the ingenic jz47xx target Thanks! > Frank > > > -- > "Debugging is twice as hard as writing the code in the first place. > Therefore, if you write the code as cleverly as possible, you are, > by definition, not smart enough to debug it." - Brian W. Kernighan Thanks i don't write code as cleverly as possible ;) -- Rafaël Carré
