Al Le wrote:
I'd also say it should go to WPS in that situation. "Repeat" refers to the continuous operation IMO. If the player is powered off, it's no "repeat" anymore. If the start screen is set to WPS that means (for me at least) that the user would like to (automatically) hear music after power on. This patch would enable that in 99.9% of cases (0.1% being the case of the first installation of Rockbox -- there is no playlist then :-).
On the other hand, if "repeat" is set to "no" that means "I want the music to stop after we reach the end of the playlist and not start until I manually resume playback or select a new song." Shutdowns can happen without user intervention (idle timeout) and booting up to playback can cause quite a disturbance if attached to speakers when the user knew it was "stopped" and the playlist complete when they shut down.
There's a difference between booting up and resuming a playlist in-progress, and booting up and starting a playlist that had ended.
I'm just saying, a resume on boot when playback had "ended" from the user's perception could cause a nasty shock, and even hearing damage if they've moved from speakers to headphones or similar.
