Re: kugel: r24335 - in trunk/apps: . gui plugins/pictureflow

[Thomas Martitz]

Am 27.01.2010 04:03, schrieb Teruaki Kawashima:
Date: 2010-01-26 21:14:42 +0100 (Tue, 26 Jan 2010)
New Revision: 24335
Log Message:
Accept the last patch FS#10797 with a few changes by me (fixing side 
effects and adding the new backdrop_hide() to the multi screen api). 
It changes the hide_bars parameter to mean hide_theme.
This makes plugins show the menu backdrop in their backdrop so that 
they don't look like crap if you have an sbs and look more 
integrated. I've test about all plugins and all work fine.


Modified: trunk/apps/plugins/pictureflow/pictureflow.c
===================================================================
--- trunk/apps/plugins/pictureflow/pictureflow.c    2010-01-25 
23:11:17 UTC (rev 24334)
+++ trunk/apps/plugins/pictureflow/pictureflow.c    2010-01-26 
20:14:42 UTC (rev 24335)
@@ -2019,6 +2019,7 @@
  void cleanup(void *parameter)
  {
      (void) parameter;
+    int i;
  #ifdef HAVE_ADJUSTABLE_CPU_FREQ
      rb->cpu_boost(false);
  #endif
@@ -2029,6 +2030,8 @@
  #ifdef USEGSLIB
      grey_release();
  #endif
+    FOR_NB_SCREENS(i)
+        rb->viewportmanager_theme_undo(i, false);
  }

  /**
@@ -2076,7 +2079,7 @@
      };

      do {
-        selection=rb->do_menu(&settings_menu,&selection, NULL, false);
+        selection=rb->do_menu(&settings_menu,&selection, NULL, true);
          switch(selection) {
              case 0:
                  rb->set_bool("Show FPS",&show_fps);
@@ -2168,7 +2171,7 @@
  #endif
                                              "Settings", "Return", 
"Quit");
      while (1)  {
-        switch (rb->do_menu(&main_menu,&selection, NULL, false)) {
+        switch (rb->do_menu(&main_menu,&selection, NULL, true)) {
              case PF_GOTO_WPS: /* WPS */
                  return -2;
  #if PF_PLAYBACK_CAPABLE
@@ -2732,11 +2735,11 @@

  enum plugin_status plugin_start(const void *parameter)
  {
-    int ret;
+    int ret, i;
      (void) parameter;
-#if LCD_DEPTH>  1
-    rb->lcd_set_backdrop(NULL);
-#endif
+
+    FOR_NB_SCREENS(i)
+        rb->viewportmanager_theme_enable(i, false, NULL);
      /* Turn off backlight timeout */
      backlight_force_on();     /* backlight control in lib/helper.c */
  #ifdef HAVE_ADJUSTABLE_CPU_FREQ


1. Could you expalin why theme is disabled in the pictureflow's menu?
2. as theme is disabled by plugin loader, it is not needed to disable 
it again in plugins.

1. Because it fits better to the rest of pictureflow (the cover 
animation and tracklist views both have black backgrounds).
2. I wasn't aware of that. But it shouldn't hurt does it?

Best regards.