On 17 April 2010 21:16, Magnus Holmgren <[email protected]> wrote: > * It uses quite a bit of stack (about 2700 bytes, on ARM at least). Probably > not a problem, but checking stack usage could perhaps be an idea. > > * Looks like "buf" (in draw_playlist_viewer_list) can overflow. Consider > what happens if "buf_used" goes larger than "sizeof(buf)"... Suggestion: use > strlcat instead. Protects against overflow and simplifies the code. Don't > know if that's what causing the problems though. > > -- > Magnus >
fixed both those suggestions.
