Frank, sorry, It is my mistake.
When correcting it, I added it to a easily position. And I don't move new functions the end of the structure until I commit. I will move new functions the end of the structure and commit. Sincerely yours, Yoshihisa Uchida > -----Original Message----- > Sender: "Frank Gevaerts" <[email protected]> > Receiver: "[email protected]" <[email protected]> > Date: 10/07/07 20:43 > Subject: Re: uchida: r27333 - trunk/apps > > Any reason why the new functions weren't added at the end of the struct, > so PLUGIN_MIN_API_VERSION wouldn't have had to increase? > > Frank > > On Wed, Jul 07, 2010 at 01:35:30PM +0200, [email protected] wrote: > > Date: 2010-07-07 13:35:30 +0200 (Wed, 07 Jul 2010) > > New Revision: 27333 > > > > Log Message: > > plugin api: add the following functions. > > - get the viewport of the current skin. > > - update the current skin statusbar. > > > > Modified: > > trunk/apps/plugin.c > > trunk/apps/plugin.h > > > > Modified: trunk/apps/plugin.c > > =================================================================== > > --- trunk/apps/plugin.c 2010-07-07 09:33:47 UTC (rev 27332) > > +++ trunk/apps/plugin.c 2010-07-07 11:35:30 UTC (rev 27333) > > @@ -565,6 +565,11 @@ > > /* statusbars */ > > &statusbars, > > gui_syncstatusbar_draw, > > +#ifdef HAVE_LCD_BITMAP > > + sb_skin_get_info_vp, > > + sb_skin_update, > > +#endif > > + > > /* options */ > > get_settings_list, > > find_setting, > > > > Modified: trunk/apps/plugin.h > > =================================================================== > > --- trunk/apps/plugin.h 2010-07-07 09:33:47 UTC (rev 27332) > > +++ trunk/apps/plugin.h 2010-07-07 11:35:30 UTC (rev 27333) > > @@ -84,6 +84,7 @@ > > #include "scrollbar.h" > > #include "jpeg_load.h" > > #include "../recorder/bmp.h" > > +#include "statusbar-skinned.h" > > #endif > > #include "statusbar.h" > > #include "menu.h" > > @@ -144,12 +145,12 @@ > > #define PLUGIN_MAGIC 0x526F634B /* RocK */ > > > > /* increase this every time the api struct changes */ > > -#define PLUGIN_API_VERSION 188 > > +#define PLUGIN_API_VERSION 189 > > > > /* update this to latest version if a change to the api struct breaks > > backwards compatibility (and please take the opportunity to sort in any > > new function which are "waiting" at the end of the function table) */ > > -#define PLUGIN_MIN_API_VERSION 188 > > +#define PLUGIN_MIN_API_VERSION 189 > > > > /* plugin return codes */ > > enum plugin_status { > > @@ -694,6 +695,10 @@ > > /* scroll bar */ > > struct gui_syncstatusbar *statusbars; > > void (*gui_syncstatusbar_draw)(struct gui_syncstatusbar * bars, bool > > force_redraw); > > +#ifdef HAVE_LCD_BITMAP > > + struct viewport *(*sb_skin_get_info_vp)(enum screen_type screen); > > + void (*sb_skin_update)(enum screen_type screen, bool force); > > +#endif > > > > /* options */ > > const struct settings_list* (*get_settings_list)(int*count); > > > > _______________________________________________ > > rockbox-cvs mailing list > > [email protected] > > http://cool.haxx.se/cgi-bin/mailman/listinfo/rockbox-cvs > > -- > "Debugging is twice as hard as writing the code in the first place. > Therefore, if you write the code as cleverly as possible, you are, > by definition, not smart enough to debug it." - Brian W. Kernighan >
