On Wednesday, 7. September 2011 09:42:12 [email protected] wrote: > > Do we really want to allow commits directly? so little of our code ever > > gets reviewed so I would quite happily force everyone to go through > > gerrit and require someone else to OK it. It isnt hard to get someone > > else in IRC to have a quick look and push the button. > > Absolutely against requiring this. > > We trust committers to do "the right thing". > > If you have a patch you think needs this - submit to refs/for/master. > > For small commits, this would be a completely pain in the arse, and > totally unwarranted.
Second this. Can gerrit be configured to request a review optionally? Let's say one touches an unfamiliar area of the code (f.e. tagcache), then it would be nice to request a review. Thomas
