Am 08.11.2011 14:17, schrieb Jonathan Gordon:
I honestly didnt think it would be this simple! Attached is the
changes removing all dynamic pointers from the skin engine!
Very nice to see it can be done! Good work.
I'm not entirely sure what to do about the conversion macros. I am
going to keep the OFFSETTYPE() one (though open to a better name)
because it is helpful).
I disagree. It's introducing an awkward pattern (macros which
intentionally do nothing, but look like they would). Comments are for
this very purpose.
(though I
don't think changing them to functions is beneficial).
Well, they _look_ nicer. Static inline maybe?
IMO the skin_buffer should left out if it's really passed to each macro
call. The parameter can be added later when it's meaningful, presumably
in a later patch to use a per-skin buffer. Each call of the macro needs
to be changed anyway.
Best regards.
