Thanks Jeff.
I really appreciate this work. I hope to review this and your other
patches this weekend.
- Dave
On Mar 9, 2006, at 3:29 PM, Jeff Blattman wrote:
please find a proposed patch to the sandboxed AAPP component ...
summary of changes:
moved Entry, EntrySet and their subclasses to the "...sdk" java
package. i found that i needed this classes on the client as well,
and this move made packaging them separate from other roller
classes easier. this also involved some refactoring in the AAPP
impl classes. this is the bulk of the diffs as quite a few files
were moved around.
added local build.xml (.../sandbox/atomadminprotocol/build.xml)
that can build just the aapp-sdk.jar and javadocs for AAPP. not
exactly sure if this is the correct pattern.
in AtomAdminServlet, refactored serialization of AAPP objects
(consolidated code that converts AAPP objects to XML string form,
in prep for writing to stream).
fixed bug where i was returning SC_OK instead of SC_CREATED to
indicate success in POST operations (APP returns SC_CREATED).
added cache invalidation when persistent store is modified. if
someone can take a look and see if i'm doing the right thing here,
that'd be great.
fixed bug where i was setting the status code after writing to and
closing the stream.
added check to disallow deletion of the currently authenticated user
in the patch file, custom-src-web.xmlf and custom-gen-web.xmlf are
modified to include both atom and atomadmin protocol. when this is
committed, can we leave the atom admin stuff in these files, and
comment it out like we do for atom?
comments?
thanks!
<svn-new.diff.gz>
