I am okay with this these db changes as well, however I think we should rename the comment table to something a little more appropriate, like "roller_weblogcomments". We may need to setup different syntax to do that for various dbs.
Then as Dave said, I don't think we need any of that stuff for the audit log table. That table is new in 2.0, so we just need to alter it's definition in the 2.0 createdb.sql file. -- Allen On Tue, 2005-11-08 at 07:30, Dave Johnson wrote: > This patch database schema changes (shown below), so if we don't get it > into 2.0, it'll have to wait for 3.0. > > alter table comment rename to blogcomment; > alter table roller_audit_log add column comment_text varchar(255); > update roller_audit_log set comment_text = comment; > alter table roller_audit_log modify comment_text varchar(255) not > null; > alter table roller_audit_log drop column comment; > > The rename syntax is in the docs for MySQL and PostgreSQL. The > roller_audit_log table is totally unused at this point, so related > changes are not an issue. > > All in all, the patch looks very safe. > > Can I sneak it in before 2.0 goes final? > > - Dave > > > > On Nov 6, 2005, at 2:55 PM, Max Rudman wrote: > > > Hi Dave, > > > > Sorry for a long delay in getting this to you -- I got busy at the day > > job. At any rate, attached is the patch for Oracle compatibility and > > db_oracle.properties file. Here are the two main changes I had to > > make: > > > > 1) Updated createdb-raw.sql to change 'comment' table to 'blogcomment' > > and 'roller_audit_log.comment' column to 'comment_text' column. The > > reason for these is that 'comment' is a reserved word in Oracle 10g. I > > also updated XDoclet tags in the appropriate POJOs to have the above > > cahnages reflected in Hibernate mapping files. > > > > 2) Added an Oracle "if" clause to the > > HibernateRefererManagerImpl.getDaysPopularWebsites method which runs > > the JDBC-based query. > > > > There are also a few miscellaneous changes to the config files > > (build.xml, hibernate.cfg.xml) for obvious reasons. Please review and > > let me know if you have any questions. > > > > I've tested the parts where I made changes against Oracle 10g Release > > 2 on Windows. We've also had the app based on Roller code running in > > production against Oracle for some time now. However, it only uses a > > subset of Roller functionality so I am not sure about more obscure > > parts of the codebase. > > > > Max > > > > <roller-oracle-patch.txt><db_oracle.properties> >
