On Nov 8, 2005, at 10:03 PM, Allen Gilliland wrote:
On Tue, 2005-11-08 at 14:37, Dave Johnson wrote:
I've got first cuts of three of my 2.1 features ready for review:
<http://rollerweblogger.org/wiki/Wiki.jsp?
page=Proposal_CommentManagementAndModeration>
1. you mention the "comment.moderation.enabled" property, which would
allow a site admin to enable/disable comment moderation for the whole
site, but what about allowing users to enable/disable comment
moderation
on a per weblog basis? this is especially important for large sites
which may want to give their bloggers the option of comment moderation,
but not force it.
Yes, that should really be per-weblog. I left that out because I was
thinking
about your point #2 below. Currently, weblog-level config changes
require
new fields in the website table.
2. you talk about adding fields to the website and
roller_weblogcomments
table, but that means db changes, which would meant these changes would
not be possible until roller 3.0.
When I wrote this I had just changed my mind and decided that maybe
minor
schema changes are allowed in minor releases after all. What was I
thinking?
The reason to limit schema changes in minor releases is to make sure
that minor releases are easy and easy to back out of. That means two
things:
For a minor release:
1) there is no need for a long-running database upgrade script that
could
cause a site to have a significant downtime during the upgrade.
2) after the upgrade from X.A to X.B, it should be possible to revert to
the X.A release and it will still work. In other words, the old release
will work fine with the new release's database.
Roller 2.0 is a major release, because it fails both tests (and it adds
major
new features). It requires a long-running upgrade script (although, you
did
speed it up significantly). And, once group blogging is turned on, it's
not really
possible to back off to a 1.X release.
Did we really mean to completely forbid any database changes at all
in minor releases? If so, comment moderation is going to have to wait
for 3.0.
3. the part about the CommentNotificationTask seems potentially
overkill
to me. I don't really see any reason why those emails can't go out as
the comments/trackbacks happen.
A user asked for that specific feature, but I think you're right, its a
"nice to have."
<http://rollerweblogger.org/wiki/Wiki.jsp?
page=Proposal_TrackbackVerification>
same thing with modifying the roller_weblogcomments table for this one.
i think it would be okay if the for roller 2.1 there wasn't an offline
option, so you had to use the "live" method. then we can add the
offline option with roller 3.0
I guess, considering the frequency of trackbacks, we could survive with
live.
- Dave
