On Jan 13, 2006, at 12:54 PM, Allen Gilliland wrote:
I wanted to fix it because that doesn't make any sense. There is no real reason to have BasePageServlet as an abstract class and have PageServlet extend it. The current BasePageServlet *is* the PageServlet in reality, so the current object hierarchy is a bit broken and misleading. It should be ..

PageServlet - /page/*
   PreviewServlet - /preview/*

since the preview servlet is a true extension of the functionality of the PageServlet. I think little inaccuracies like this pile up and make the code less concise and ultimately harder to maintain, and that matters quite a bit to me.

We already have xdoclet inserting servlet mappings from servlets.xml and servlet-mappings.xml file in the metadata/xdoclet directory. I would prefer to correct this and put the servlet mappings in there rather than leave things the way they are now.

Why don't you go ahead and do that. I don't have any problem with that approach, but I'm not ready to ditch XDoclet for web.xml entirely (yet).

- Dave

Reply via email to