I would like to submit a small set of patches which gives the text 
client a     
 couple of features that I have wanted for a very long time.    
 These are '-' '+' (minus, plus) commands for single stepping through 
rooms     
 and the '>' and '<'  (greater, less than) key commands for going up and 
down    
 floors. While these commands are not strictly necessary, I feel they may 
add     
 a nice sense of freedom and mobility for text client users. At the very 
least,    
 though, I feel they would do no harm. I have implemented the stepping 
functions     
 so as to not muck around with existing functions or functionality. 
Hopefully    
 this reduces the possibility of introducing unexpected behavior or 
reducing     
 maintainability.  If it turns out you cannot use this code,    
 that's okay, I will still enjoy the new commands on my own build of 
citadel.      
 I do stand by my work, however, and if you have any concerns or issues I  
   
 would be more than happy to do what it takes to resolve them.    
   As a small side note, I noticed in the gotofloor function a couple of 
TODOs     
 indicating that room order is being ignored.  I included a possible fix 
for    
 this by making a small change to pop_march to take a pointer to a march 
struct    
 to give it a bit more flexibility, and then using pop_march from 
gotofloor    
 to give me the proper room name.  This was fairly simple and I hope this 
is    
 a proper fix for this.    
  Please advise me on where to send these patches and or complete files.   
 
   
  thanks, matt  
  

Reply via email to