As you all know, reactos is tested against the wine test suite. While
this is a great tool, I think this is not enough to be sure that ReactOS
is fully tested.
I've been trying to fix some kernel32 tests. As you all know, in ReactOS
it is written on top of ntdll. So I wanted to fix some tests, and then a
question arose : is it that kernel32 calls ntdll the wrong way, or is it
that ntdll does the wrong job? The only way to verify this would be to
test kernel32.dll out of reactOS, meaning replacing the windows one with
the reactos one, and run the test.
To be brief : I think that a weekly "reactos dlls against windows" test
would be very helpful to be sure that things are done the right way!
I began with the kernel32:file winetest. I managed to not make it crash
when used on winXP, the resulting patch is there :
http://www.reactos.org/bugzilla/show_bug.cgi?id=4728 and the result of
this test is attached there. As miracles happen, it also fixes some
tests on ReactOS. Seems like this is a good approach.
Jérôme Gardou (aka zefklop on IRC and forums)
file.c:583: Test failed: failed to open source file
file.c:585: Test failed: WriteFile error 6
file.c:587: Test failed: source file has wrong size
file.c:590: Test failed: GetFileTime error 6
file.c:593: Test failed: SetFileTime error 6
file.c:602: Test failed: CopyFileA: unexpected error 5
file.c:606: Test failed: CopyFileA: error 5
file.c:610: Test failed: failed to open destination file
file.c:612: Test failed: destination file has wrong size -1
file.c:616: Test failed: GetFileTime error 6
file.c:617: Test failed: destination file has wrong filetime
file.c:621: Test failed: CopyFileA: ret = 0, unexpected error 5
file.c:626: Test failed: destination file has wrong size -1
file.c:628: Test failed: ReadFile: error 6
file.c:630: Test failed: buffer contents mismatch
file.c:634: Test failed: DeleteFileA: error 5
file.c:636: Test failed: DeleteFileA: error 5
file.c:662: Test failed: CopyFileW: unexpected error 5
file.c:666: Test failed: CopyFileW: error 5
file.c:669: Test failed: DeleteFileW: error 5
file.c:671: Test failed: DeleteFileW: error 5
file.c:747: Test failed: CREATE_NEW should fail if file exists and last error
value should be ERROR_FILE_EXISTS
file.c:753: Test failed: hFile FFFFFFFF, last error 5
file.c:761: Test failed: hFile FFFFFFFF, last error 5
file.c:767: Test failed: DeleteFileA: error 5
file.c:772: Test failed: hFile FFFFFFFF, last error 5
file.c:778: Test failed: DeleteFileA: error 5
file.c:791: Test failed: Createdirectory failed, gle=183
file.c:827: Tests skipped: Either no authority to volume, or is todo_wine for
C:\WINDOWS\TEMP\ err=5 should be 3
file.c:829: Tests skipped: Do not have authority to access volumes. Test for
C:\WINDOWS\TEMP\ skipped
file.c:827: Tests skipped: Either no authority to volume, or is todo_wine for
C:\WINDOWS\TEMP\removeme\ err=5 should be 3
file.c:829: Tests skipped: Do not have authority to access volumes. Test for C:
skipped
file.c:827: Tests skipped: Either no authority to volume, or is todo_wine for
C:\ err=5 should be 3
file.c:829: Tests skipped: Do not have authority to access volumes. Test for
C:\ skipped
file.c:829: Tests skipped: Do not have authority to access volumes. Test for
\\?\C: skipped
file.c:827: Tests skipped: Either no authority to volume, or is todo_wine for
\\?\C:\ err=5 should be 3
file.c:851: Test failed: RemoveDirectoryA: error 87
file.c:879: Tests skipped: Probable Win9x, got ERROR_PATH_NOT_FOUND w/
FILE_FLAG_BACKUP_SEMANTICS or C:\WINDOWS\TEMP\
file.c:964: Tests skipped: Do not have authority to access volumes. Tests
skipped
file.c:974: Test failed: GetVolumeNameForVolumeMountPointA failed, for C:\,
last error=5
file.c:1053: Tests skipped: GetVolumeNameForVolumeMountPointA not functioning
file.c:1084: Test failed: CREATE_NEW should fail if file exists and last error
value should be ERROR_FILE_EXISTS
file.c:1090: Test failed: hFile FFFFFFFF, last error 5
file.c:1098: Test failed: hFile FFFFFFFF, last error 5
file.c:1104: Test failed: DeleteFileW: error 5
file.c:1109: Test failed: hFile FFFFFFFF, last error 5
file.c:1115: Test failed: DeleteFileW: error 5
file.c:1138: Test failed: couldn't create temporary directory
file.c:1145: Test failed: DeleteFileW: error 87
file.c:1240: Test failed: couldn't create directory deletefile
file.c:1244: Test failed: expected to remove directory deletefile
file.c:1248: Test failed: couldn't create directory deletefile
file.c:1250: Test failed: couldn't create directory deletefile\sub
file.c:1254: Test failed: expected to remove directory deletefile\sub
file.c:1256: Test failed: expected to remove directory deletefile
file.c:1279: Test failed: MoveFileA: unexpected error 5
file.c:1283: Test failed: DeleteFileA: error 5
file.c:1290: Test failed: CreateDirectoryA failed
file.c:1298: Test failed: MoveFileA: with wildcards, unexpected error 6
file.c:1325: Test failed: DeleteFileA: error 5
file.c:1329: Test failed: DeleteDirectoryA: error 87
file.c:1355: Test failed: CopyFileW: unexpected error 5
file.c:1359: Test failed: DeleteFileW: error 5
file.c:1361: Test failed: DeleteFileW: error 5
file.c:1736: Test failed: Bad Error number 2
file.c:1746: Test failed: Bad Error number 2
file.c:1755: Test failed: Bad Error number 2
file.c:1764: Test failed: Bad Error number 2
file.c:1814: Test failed: Bad Error number 2
file.c:1897: Test failed: Fetching fourth file failed
file.c:1900: Test failed: Fetching fifth file failed
file.c:1385: Test failed: CreateFileA error 5
file.c:1389: Test failed: WriteFile error 6
file.c:1390: Test failed: expected number of bytes written 0
file.c:1398: Test failed: WriteFile error 6
file.c:1399: Test failed: expected number of bytes written 0
file.c:1401: Test failed: wrong file offset -1
file.c:1406: Test failed: WriteFile error 6
file.c:1407: Test failed: expected number of bytes written 0
file.c:1409: Test failed: wrong file offset -1
file.c:1417: Test failed: CreateFileA error 5
file.c:1426: Test failed: ReadFile error 6
file.c:1427: Test failed: expected number of bytes read 0
file.c:1429: Test failed: wrong file offset -1
file.c:1430: Test failed: pattern match failed
file.c:1436: Test failed: DeleteFileA error 5
file.c:2060: Test failed: CreateFileA: error 5
file.c:2065: Test failed: ret = 0, error 6
file.c:2072: Test failed: ret = 0, error 6
file.c:2086: Test failed: ret = 0, error 6
file.c:2093: Test failed: ret = 0, error 6
file.c:2104: Test failed: WriteFile failed error 6
file.c:2105: Test failed: only wrote 0 bytes
file.c:2112: Test failed: wrong error 6
file.c:2129: Test failed: wrong error 6
file.c:2138: Test failed: wrong error 6
file.c:2148: Test failed: wrong error 6
file.c:2158: Test failed: wrong error 6
file.c:2169: Test failed: wrong error 6
file.c:2175: Test failed: ReadFile failed error 6
file.c:2176: Test failed: read 0 bytes
file.c:2180: Test failed: wrong error 6
file.c:2188: Test failed: CloseHandle: error 6
file.c:2190: Test failed: DeleteFileA: error 5
file.c:2255: Test failed: OpenFile set ofs.cBytes to 136
file.c:2277: Test failed: OpenFile set ofs.cBytes to 136
file.c:2465: Test failed: Createdirectory failed, gle=183
file.c:2477: Test failed: RemoveDirectory failed, gle=87
file.c:2522: Test failed: failed to open replaced file
file.c:2525: Test failed: WriteFile error (replaced) 6
file.c:2527: Test failed: replaced file has wrong size
file.c:2531: Test failed: failed to open replacement file
file.c:2534: Test failed: WriteFile error (replacement) 6
file.c:2536: Test failed: replacement file has wrong size
file.c:2540: Test failed: failed to open backup file
file.c:2543: Test failed: WriteFile error (replacement) 6
file.c:2545: Test failed: backup file has wrong size
file.c:2549: Test failed: GetFileTime error (replaced) 6
file.c:2552: Test failed: SetFileTime error (replaced) 6
file.c:2557: Test failed: GetFileTime error (backup) 6
file.c:2560: Test failed: SetFileTime error (backup) 6
file.c:2565: Test failed: GetFileTime error (replacement) 6
file.c:2573: Test failed: ReplaceFileA: unexpected error 1175
file.c:2576: Test failed: failed to open backup file
file.c:2579: Test failed: backup file has wrong size -1
file.c:2583: Test failed: failed to open replaced file: 5
file.c:2609: Tests skipped: couldn't open replacement file, skipping tests
file.c:2619: Test failed: ReplaceFileA: unexpected error 1175
file.c:2626: Test failed: DeleteFileA: error (backup) 5
file.c:2632: Test failed: ReplaceFileA: unexpected error 1175
file.c:2651: Test failed: unexpected error, replacement file should still exist
5
file.c:2668: Test failed: ReplaceFileA: unexpected error 1175
file.c:2677: Test failed: ReplaceFileA: unexpected error 1175
file.c:2734: Test failed: ReplaceFileW: error 1175
file.c:2739: Test failed: ReplaceFileW: error 1175
file.c:2745: Test failed: DeleteFileW: error (backup) 5
file.c:2747: Test failed: ReplaceFileW: error 1175
file.c:2766: Test failed: DeleteFileW: error (replaced) 5
file.c:2771: Test failed: ReplaceFileW: unexpected error 1175
file: 496077 tests executed (0 marked as todo, 127 failures), 12 skipped.
_______________________________________________
Ros-dev mailing list
[email protected]
http://www.reactos.org/mailman/listinfo/ros-dev
